@hasannadeem there is one failing spec right now.

@hasannadeem there is one failing spec right now.

Sure, I am fixing the spec, but I just double-checked it, and it’s not failing because of my changes.

Hey @ronaldtse, I have fixed the specs as well.

Hey @ronaldtse, i have tested this pr on https://github.com/rnpgp/rnpgp.github.io.

I first tried to running the project with the existing code(not with rx-prexus) and ended up getting the following error.

Then I ran the project(https://github.com/rnpgp/rnpgp.github.io.) with this pr and it is working smoothly. As you can see in the screenshoots.

On the rnpgp page, are we missing the landing/hero image? It needs to look like the current website at www.rnpgp.org. Thanks!

Also @hasannadeem could you help test it on the hub site (https://github.com/riboseinc/open.ribose.com/)? Thanks!

On the rnpgp page, are we missing the landing/hero image? It needs to look like the current website at www.rnpgp.org. Thanks!

Hey @ronaldtse, which hero image are you referring here? Could you please specify or attach a SS?

I was mistaken -- not the hero image but the hero text, and this layout:

Also @hasannadeem could you help test it on the hub site (https://github.com/riboseinc/open.ribose.com/)? Thanks!

Hey @ronaldtse, i have tested the hub site with the rename gem pr and here is the SS.

I have also tested the hub site with my PR and here is the SS.

@hasannadeem

1. I need the rnpgp.org site to look exactly like how it is today as shown in the screenshot
2. I need the https://open.ribose.com site to look exactly how it is today

The PR was incomplete, that's why it was broken. We can only merge the PR when it is complete (i.e. the sites render properly as I've shown in screenshots). Thanks.

@hasannadeem I just realized that actually nothing is fixed here.

This is the reason that I mentioned to actually test with actual sites not just the specs/ because it is possible to misunderstand what the specs mean.

The specs do not mean that you "add a sample image to the gem and them use it to pass tests", this is the reason why there is "no sample image at the /assets directory of the gem".

The symbol.svg file is meant to be read from "not the gem" but from the actual (hub or project) site that "uses the gem". I don't know how I can explain further here.